Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Fix download action #2842

Merged
merged 3 commits into from
May 16, 2022
Merged

Conversation

Daniel-WWU-IT
Copy link
Contributor

The download action was no longer working in the SDK (used by our testing probes); this PR fixes the underlying issue.

@update-docs
Copy link

update-docs bot commented May 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@Daniel-WWU-IT Daniel-WWU-IT requested review from glpatcern and a team as code owners May 9, 2022 07:58
@micbar
Copy link
Member

micbar commented May 9, 2022

@Daniel-WWU-IT Please check if you really need this change. oCIS and ownCloud Web are using ID based requests. They use the code from reva edge branch.

@Daniel-WWU-IT
Copy link
Contributor Author

Daniel-WWU-IT commented May 9, 2022

@micbar This change is needed and only affects the SDK - which is used by our testing probes (has nothing to do with code checks). It solely reflects how the Reva CLI works... w/o this change, downloads simply won't work (at least with the none-edge Reva), but we obviously need them to work ;) This change shouldn't have anything to do with ownCloud or any other integration stuff at all.

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@labkode labkode merged commit b62ead5 into cs3org:master May 16, 2022
@Daniel-WWU-IT Daniel-WWU-IT deleted the sdk-download-fix branch May 16, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants